Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize CpuClock, make non-exhaustive, rename variants #2899

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Jan 7, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

  • mark unstable items in clocks as unstable or doc-hide
  • rename enum variants
  • make CpuClock non-exhaustive

Testing

CI (failing SPI tests on ESP32 seem to be unrelated)

@bjoernQ bjoernQ force-pushed the stabilize-cpu-clock branch from c35705a to 5ae9c39 Compare January 7, 2025 12:31
@bjoernQ bjoernQ marked this pull request as ready for review January 7, 2025 13:09
@bjoernQ bjoernQ linked an issue Jan 7, 2025 that may be closed by this pull request
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham added this pull request to the merge queue Jan 7, 2025
Merged via the queue into esp-rs:main with commit 66d2eff Jan 7, 2025
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilizing CpuClock
3 participants