Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to use esp-box and t-deck components #7

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

finger563
Copy link
Contributor

Description

  • Update to remove lcd and box/t-deck headers in favor of reusing the code from the espp::EspBox and espp::TDeck classes
  • Update actions to use latest versions
  • Update submodules to latest
  • Add a few things to defaults

Motivation and Context

Allows for more complex development by re-using code from existing components - potentially allowing audio or other more complex UI in the future a lot more easily. Also helps keep the code a little easier to follow / understand.

How has this been tested?

Building main and running it on ESP32-S3-BOX-3.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update to remove lcd and box/t-deck headers in favor of reusing the code from the `espp::EspBox` and `espp::TDeck` classes
* Update actions to use latest versions
* Update submodules to latest
* Add a few things to defaults
@finger563 finger563 self-assigned this Jul 6, 2024
@finger563 finger563 added enhancement New feature or request esp32-s3-box esp32-s3-box-3 lilygo t-deck hal hardware abstraction layer labels Jul 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 90f55f5 into main Jul 6, 2024
2 checks passed
@finger563 finger563 deleted the feature/espp-hal-components branch July 6, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request esp32-s3-box esp32-s3-box-3 hal hardware abstraction layer lilygo t-deck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant