-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Config File Improvements #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
I'm definitely in favor of refactoring the config logic. I left a few questions about what changes are user-facing.
Co-Authored-By: mysticatea <[email protected]>
Co-Authored-By: mysticatea <[email protected]>
I updated this RFC.
|
I updated this RFC about the plugin resolution change. |
I separated the enhancement part from the core proposal because the mix of simplification and enhancement proposals is not readable.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for separating the proposal into different parts -- that definitely makes it easier to review.
designs/2019-eslintrc-improvements/major-02-plugin-resolution-change.md
Outdated
Show resolved
Hide resolved
designs/2019-eslintrc-improvements/major-02-plugin-resolution-change.md
Outdated
Show resolved
Hide resolved
I removed an additional enhancement proposal "Plugin Resolution Change" from this RFC. This RFC now doesn't change plugin resolution way. The important pain that "Plugin Resolution Change" tried to solve is solved by Plugin Renaming proposal without any breaking change. |
Thank you to be interested in this RFC. You can install
Then you can use it as same as normal ESLint. |
Link to Rendered RFC (core proposal)
Summary
This proposal improves our configuration files. This changes the architecture of configuration files to maintain our codebase easier and make enhancing easier.
This RFC fixes two bugs I found while I make a PoC. I guess we don't want to make surprised behaviors on purpose.
overrides
in shareable configs no longer overwrites user settings in.eslintrc
files. (see details)This RFC includes four enhancements.
extends
inoverrides
(minor) (fixes eslint/eslint#8813)I made the enhancements in my PoC in order to confirm this architecture change is effective to maintain our codebase easier and make enhancing easier. Therefore, the enhancements are not required for this proposal.
However, I'd like to add the enhancements with this because those will solve some important pain of the ecosystem.
Related Issues
eslintrc
or other config files eslint#11223