fix!: remove nodejsScope option
#699
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
|
Note: uses of this property will be removed from ESLint in eslint/eslint#20145. |
mdjermanovic
commented
Oct 16, 2025
Comment on lines
-84
to
-112
| it("creates a function scope following the global scope immediately and creates module scope", () => { | ||
| const ast = espree("import {x as v} from 'mod';"); | ||
|
|
||
| const scopeManager = analyze(ast, { ecmaVersion: 6, nodejsScope: true, sourceType: "module" }); | ||
|
|
||
| expect(scopeManager.scopes).to.have.length(3); | ||
| expect(scopeManager.isGlobalReturn()).to.be.true; | ||
|
|
||
| let scope = scopeManager.scopes[0]; | ||
|
|
||
| expect(scope.type).to.be.equal("global"); | ||
| expect(scope.block.type).to.be.equal("Program"); | ||
| expect(scope.isStrict).to.be.false; | ||
| expect(scope.variables).to.have.length(0); | ||
|
|
||
| scope = scopeManager.scopes[1]; | ||
| expect(scope.type).to.be.equal("function"); | ||
| expect(scope.block.type).to.be.equal("Program"); | ||
| expect(scope.isStrict).to.be.false; | ||
| expect(scope.variables).to.have.length(1); | ||
| expect(scope.variables[0].name).to.be.equal("arguments"); | ||
|
|
||
| scope = scopeManager.scopes[2]; | ||
| expect(scope.type).to.be.equal("module"); | ||
| expect(scope.variables).to.have.length(1); | ||
| expect(scope.variables[0].name).to.be.equal("v"); | ||
| expect(scope.variables[0].defs[0].type).to.be.equal("ImportBinding"); | ||
| expect(scope.references).to.have.length(0); | ||
| }); |
There was a problem hiding this comment.
This test was inherited from escope. I'm not sure why nodejsScope: true, sourceType: "module" combination was supported at all, and even less why it was supported by nesting scopes as: Global > Function > Module. For this combination, I think Global > Module > Function would make more sense for practical purposes as it could represent code that is going to be wrapped in a function that is in an ES module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Removes
nodejsScopeoption fromeslint-scope.What changes did you make? (Give an overview)
Removed the option and updated
analyze()to throw an error if it's passed.Related Issues
Fixes #697
Is there anything you'd like reviewers to focus on?