-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the eslint-scope
package
#615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The moved files look good. We also need to update release-please-config.json
and .release-please-manifest.json
to ensure that release-please knows about this package.
languageOptions: { | ||
globals: { | ||
...globals.mocha | ||
} | ||
}, | ||
plugins: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to add more to this config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is to match the eslint-scope ESLint config.
I merged both the configs, but, I think we can have different config for packages/espree/tests/lib/**
& packages/eslint-scope/tests/lib/**
too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can have different config for
packages/espree/tests/lib/**
&packages/eslint-scope/tests/lib/**
Sounds good to me to have different configs, because eslint-scope tests use chai
while espree tests don't (I'm not sure why chai
was listed in espree dev deps).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, also removed chai from espree's dev dep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we also need to add eslint-scope
to the issue templates.
Updated 👍🏻 |
Looks like When I add
In the old eslint-scope repo, it logs:
So it seems that the license check effectively wouldn't work? I'm not sure how this could be fixed and whether we need a license check for the eslint-scope package. We have a license check in eslint/eslint, and eslint-scope seems to be the only other package with this check. |
In a monorepo, all dependencies end up in the top-level |
Providing the top-level path here also didn't work, it was then outputting For now, I have passed additional metadata (See 6405974) to keep the behavior the same as eslint-scope repo, I think we can follow up on this and see how it can be improved for monorepo. |
@@ -0,0 +1,110 @@ | |||
[![npm version](https://img.shields.io/npm/v/eslint-scope.svg)](https://www.npmjs.com/package/eslint-scope) | |||
[![Downloads](https://img.shields.io/npm/dm/eslint-scope.svg)](https://www.npmjs.com/package/eslint-scope) | |||
[![Build Status](https://github.com/eslint/eslint-scope/workflows/CI/badge.svg)](https://github.com/eslint/eslint-scope/actions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update the link after the repo being renamed.
[![Build Status](https://github.com/eslint/eslint-scope/workflows/CI/badge.svg)](https://github.com/eslint/eslint-scope/actions) | |
[![Build Status](https://github.com/eslint/eslint-scope/workflows/CI/badge.svg)](https://github.com/eslint/js/actions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update it only after the repo is renamed,
{ | ||
"name": "eslint-scope", | ||
"description": "ECMAScript scope analyzer for ESLint", | ||
"homepage": "http://github.com/eslint/eslint-scope", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"homepage": "http://github.com/eslint/eslint-scope", | |
"homepage": "https://github.com/eslint/js#readme", |
"engines": { | ||
"node": "^18.18.0 || ^20.9.0 || >=21.1.0" | ||
}, | ||
"repository": "eslint/eslint-scope", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"repository": "eslint/eslint-scope", | |
"repository": "eslint/js", |
"repository": "eslint/eslint-scope", | ||
"funding": "https://opencollective.com/eslint", | ||
"bugs": { | ||
"url": "https://github.com/eslint/eslint-scope/issues" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"url": "https://github.com/eslint/eslint-scope/issues" | |
"url": "https://github.com/eslint/js/issues" |
@snitin315 are you still working on this? |
@nzakas Yes, somehow I missed the last review notification. I've updated the PR, PTAL. @aladdin-add Let's change the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending @nzakas re-review. thanks!
All right, moving this forward. I will rename the repo now. |
Refers #609