Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: bundle espree (fixes eslint/eslint.github.io#546) #11467

Merged
merged 3 commits into from
Mar 5, 2019

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Mar 3, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
fixes eslint/archive-website#546

Is there anything you'd like reviewers to focus on?

the commit message checking failing -- how to fix a cross-repo issue?

@aladdin-add aladdin-add added bug ESLint is working incorrectly build This change relates to ESLint's build process accepted There is consensus among the team that this change meets the criteria for inclusion labels Mar 3, 2019
@aladdin-add aladdin-add changed the title Build: bundle espree (fixes eslint/espree#546) Build: bundle espree (fixes eslint/eslint.github.io#546) Mar 3, 2019
webpack.config.js Outdated Show resolved Hide resolved
@platinumazure
Copy link
Member

Thanks for the PR!

I think the bot just never had to worry about cross-repository fixes before- we could certainly enhance to allow that case. I wouldn't have a problem merging this with the commit message "error", assuming any other issues are fixed.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with how webpack config files work, but this seems fine if we've confirmed that it works.

@not-an-aardvark not-an-aardvark merged commit fe1a892 into eslint:master Mar 5, 2019
@aladdin-add aladdin-add deleted the build/espree branch March 5, 2019 02:34
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 2, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly build This change relates to ESLint's build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: espree demo not working
5 participants