-
-
Notifications
You must be signed in to change notification settings - Fork 32
feat!: remove eslint v8 / eslintrc support and remove flat/
prefix from configs
#528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove eslint v8 / eslintrc support and remove flat/
prefix from configs
#528
Conversation
This change removes support for legacy rc-based configs, and moves minimum supported version to 9.0. I've also removed the deprecated `/configs` entry point.
Can you cherry-pick my commit from this PR to include the RuleTester update? Then I can close my PR. |
Your PR removed our |
tests/utils/test-setup.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR removed our RuleTester, but with the vitest change (which I believe was still in PR, when your change went up), we still need to attach vitest's functions to RuleTester. So I removed the v8 specific logic from it, but left the vitest augmentation. I think this will cover what was in your change?
@michaelfaith I just pushed this change to solve that so rule test files can use the standard RuleTester import. Look good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! That's much cleaner. Thanks.
flat/
prefix from configs
lib/index.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some more context about the config names btw:
I think the current plan to just drop ESLint v8 / eslintrc now is fine.
}, | ||
], | ||
import eslintPlugin from 'eslint-plugin-eslint-plugin'; | ||
import packageMetadata from './package.json' with { type: 'json' }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: 130:29 error Can't resolve './package.json' in '/home/runner/work/eslint-plugin-eslint-plugin/eslint-plugin-eslint-plugin/docs/rules/require-meta-docs-url.md' n/no-missing-import
You can disable that lint rule for this file if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example of disabling a lint rule for markdown code sample:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I had 'n/no-missing-imports'
instead of 'n/no-missing-import'
doh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This change removes support for legacy rc-based configs, and moves minimum supported version to 9.0. I've also removed the deprecated
/configs
entry point. Please use the plugin'sconfigs
object.Contributes to #505