-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Review of already merged code #1
Open
arcusfelis
wants to merge
24
commits into
empty-branch
Choose a base branch
from
main
base: empty-branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, I didn't know you could do so many things on the browser. Very well done, readable code and everything! 😄
Oh and that PR description, gorgeous! |
NelsonVides
added a commit
to esl/MongooseIM
that referenced
this pull request
Sep 6, 2024
Optimize (compress) ct_report logs on CI and read them using a service worker in Browser This PR addresses MIM-2283 "Optimize (compress) ct_report logs somehow on CI" Proposed changes include: Compress files into tar.gz. We use https://github.com/esl/html-zip-reader to read the archive and serve it using a service worker. The logic for the service worker could be reviewed in this PR: esl/html-zip-reader#1 We can maybe stop using s3-parallel-put (unless it is smaller than awscli tools). But in a separate PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to do coding in the main branch, so gh-pages are built.
Still, we could do a basic code review.
Here is a diff PR.
You can review it, just do not merge it, please.
So, how it works.
404.html handles any not-found-pages by default in gh-pages.
In 404.html we have the code "for control interface". Control interface allows to install/uninstall worker and view logs from the worker.
404.html would be hit when a user first time presses a link to the file in archive. It would install the service worker and reload the page.
Once service worker is installed, it would handle
onfetch
method.Fetch allows to handle requests to the domain, in a way similar to how proxy works.
So, if we see in the method, that a user wants to read something from the archive, we:
tar.gz
archive.Response
with the data. If not found, we write "oops, not found" if file is supposed to be in the archive. Otherwise we just allow browser to ask github pages and ignore the worker.