-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that unavailable_nodes list is a subset of discovered_nodes #35
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 97.38% 97.46% +0.07%
==========================================
Files 9 9
Lines 612 630 +18
==========================================
+ Hits 596 614 +18
Misses 16 16
☔ View full report in Codecov by Sentry. |
ae28a33
to
bb4b3f8
Compare
Add status_discovered_nodes testcase
adeb5ce
to
bb017a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - I only added minor style-related comments.
added meck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Addresses "MIM-2054 CETS status: removed nodes from disco should not be listed in a list of unavailable nodes"
Changes:
DiscoOpts
in tests instead of constructing the same map twice (small refactoring)Nodes could be removed from the discovery_nodes table after some time.
After that point, the removed node should not appear in the systemInfo API.
But we currently we can have:
We need to ensure that unavailableNodes is a subset of discoveredNodes before returning it to the user.