Remove unneeded ok-s from functions

esl · Aug 31, 2023 · 1d99195 · 1d99195
1 parent 690be9d
commit 1d99195
Showing 1 changed file with 9 additions and 14 deletions.
diff --git a/test/cets_SUITE.erl b/test/cets_SUITE.erl
@@ -710,8 +710,7 @@ test_multinode(Config) ->
     insert_many(Node4, Tab, [{m}, {a}, {n}, {y}]),
     Same([{a}, {b}, {c}, {d}, {f}, {m}, {n}, {y}]),
     delete_many(Node4, Tab, [a, n]),
-    Same([{b}, {c}, {d}, {f}, {m}, {y}]),
-    ok.
+    Same([{b}, {c}, {d}, {f}, {m}, {y}]).
 
 test_multinode_remote_insert(Config) ->
     Tab = make_name(Config),
@@ -739,8 +738,7 @@ node_list_is_correct(Config) ->
     [Node2, Node3, Node4] = other_nodes(Node1, Tab),
     [Node1, Node3, Node4] = other_nodes(Node2, Tab),
     [Node1, Node2, Node4] = other_nodes(Node3, Tab),
-    [Node1, Node2, Node3] = other_nodes(Node4, Tab),
-    ok.
+    [Node1, Node2, Node3] = other_nodes(Node4, Tab).
 
 test_multinode_auto_discovery(Config) ->
     Node1 = node(),
@@ -759,8 +757,7 @@ test_multinode_auto_discovery(Config) ->
     [#{memory := _, nodes := [Node1, Node2], size := 0, table := Tab}] =
         cets_discovery:info(Disco),
     #{verify_ready := []} =
-        cets_discovery:system_info(Disco),
-    ok.
+        cets_discovery:system_info(Disco).
 
 test_disco_add_table(Config) ->
     Node1 = node(),
@@ -778,8 +775,7 @@ test_disco_add_table(Config) ->
     ok = cets_discovery:wait_for_ready(Disco, 5000),
     [Node2] = other_nodes(Node1, Tab),
     [#{memory := _, nodes := [Node1, Node2], size := 0, table := Tab}] =
-        cets_discovery:info(Disco),
-    ok.
+        cets_discovery:info(Disco).
 
 test_disco_file_appears(Config) ->
     Node1 = node(),
@@ -802,8 +798,7 @@ test_disco_file_appears(Config) ->
     ok = cets_discovery:wait_for_ready(Disco, 5000),
     [Node2] = other_nodes(Node1, Tab),
     [#{memory := _, nodes := [Node1, Node2], size := 0, table := Tab}] =
-        cets_discovery:info(Disco),
-    ok.
+        cets_discovery:info(Disco).
 
 test_disco_handles_bad_node(Config) ->
     Node1 = node(),
@@ -899,8 +894,7 @@ test_disco_add_two_tables(Config) ->
         #{memory := _, nodes := [Node1, Node2], size := 0, table := Tab1},
         #{memory := _, nodes := [Node1, Node2], size := 0, table := Tab2}
     ] =
-        cets_discovery:info(Disco),
-    ok.
+        cets_discovery:info(Disco).
 
 disco_retried_if_get_nodes_fail(Config) ->
     Node1 = node(),
@@ -916,8 +910,7 @@ disco_retried_if_get_nodes_fail(Config) ->
     cets_test_wait:wait_until(
         fun() -> maps:get(last_get_nodes_retry_type, cets_discovery:system_info(Disco)) end,
         after_error
-    ),
-    ok.
+    ).
 
 disco_uses_regular_retry_interval_in_the_regular_phase(Config) ->
     Node1 = node(),
@@ -1256,6 +1249,8 @@ send_leader_op_throws_noproc(_Config) ->
                 matched
         end.
 
+%% Netsplit cases (run in sequence)
+
 insert_returns_when_netsplit(Config) ->
     #{ct5 := Node2} = proplists:get_value(peers, Config),
     Node1 = node(),