Skip to content

style(desktop): restore detailed macOS whale icon - #7124

Draft
LouF666 wants to merge 2 commits into
esengine:main-v2from
LouF666:style/macos-detailed-whale-icon
Draft

style(desktop): restore detailed macOS whale icon#7124
LouF666 wants to merge 2 commits into
esengine:main-v2from
LouF666:style/macos-detailed-whale-icon

Conversation

@LouF666

@LouF666 LouF666 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Depends on fix(desktop): restore macOS icon safe area #7123 and intentionally remains a draft until that packaging fix lands.
  • Replace only the macOS-specific SVG and ICNS with the detailed whale artwork while retaining the exact 100..924 (824×824) safe area introduced by the dependency PR.
  • Keep the shared Windows and Linux full-canvas icon assets unchanged.

The detailed artwork was originally contributed by @SivanCola in #4321. The macOS safe-area adaptation follows the direction proposed by @idoaix in #6156. Both authors are retained as Co-authored-by trailers in this PR's artwork commit.

After #7123 merges, this branch will be rebased onto main-v2 and moved out of draft.

Issues

Refs #6156

Verification

  • (cd desktop && go test . -run 'Test(DarwinICNS|AppIconPNG|WindowsICO|DesktopPackagesPreserveNativePlatformLaunchers)')
  • (cd desktop && go test ./...)
  • (cd desktop && go vet ./...)
  • Confirmed the committed ICNS ic10 frame has a 1024×1024 canvas and exact visible bounds of (100,100)-(924,924).
  • Applied the same detailed ICNS to Reasonix 1.18.0 on macOS 15.7.8 and visually checked it in Dock and Launchpad against adjacent applications.

Cache impact

Cache-impact: none — this only replaces macOS artwork; provider-visible prompts and request serialization are untouched.
Cache-guard: Existing cache-sensitive surfaces are untouched; the ICNS bounds regression test from dependency PR #7123 covers this asset.
System-prompt-review: N/A

LouF666 and others added 2 commits August 1, 2026 12:30
Co-authored-by: SivanCola <liuxw96@foxmail.com>
Co-authored-by: Miles <wangxiaodimail@gmail.com>
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) updater Auto-update / installer / release packaging labels Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Wails desktop app (desktop/**) updater Auto-update / installer / release packaging v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant