style(desktop): restore detailed macOS whale icon - #7124
Draft
LouF666 wants to merge 2 commits into
Draft
Conversation
Co-authored-by: SivanCola <liuxw96@foxmail.com> Co-authored-by: Miles <wangxiaodimail@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
100..924(824×824) safe area introduced by the dependency PR.The detailed artwork was originally contributed by @SivanCola in #4321. The macOS safe-area adaptation follows the direction proposed by @idoaix in #6156. Both authors are retained as
Co-authored-bytrailers in this PR's artwork commit.After #7123 merges, this branch will be rebased onto
main-v2and moved out of draft.Issues
Refs #6156
Verification
(cd desktop && go test . -run 'Test(DarwinICNS|AppIconPNG|WindowsICO|DesktopPackagesPreserveNativePlatformLaunchers)')(cd desktop && go test ./...)(cd desktop && go vet ./...)ic10frame has a 1024×1024 canvas and exact visible bounds of(100,100)-(924,924).Cache impact
Cache-impact: none — this only replaces macOS artwork; provider-visible prompts and request serialization are untouched.
Cache-guard: Existing cache-sensitive surfaces are untouched; the ICNS bounds regression test from dependency PR #7123 covers this asset.
System-prompt-review: N/A