Issue#412 #418
Open
Issue#412 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
force-pushed
the
issue#412
branch
2 times, most recently
from
54e30ea
to
e44022d
Compare
ljharb
requested changes
Jan 7, 2020
es5-shim.js
Outdated
| } | ||
|
|
||
| if (result[groupIndex] && !result[groupIndex].isResulting) { | ||
| result.splice(groupIndex, 1); |
There was a problem hiding this comment.
we should definitely not rely on:
spliceworking properlysplicebeing present
nor should we mutate the array like this.
es5-shim.js
Outdated
| searchValue.lastIndex = originalLastIndex; // eslint-disable-line no-param-reassign | ||
| pushCall(args, arguments[length - 2], arguments[length - 1]); | ||
| return replaceValue.apply(this, args); | ||
| var groups = ArrayPrototype.slice.call(arguments, 1, -2); |
There was a problem hiding this comment.
delete Array.prototype.slice would break this code.
Suggested change
| var groups = ArrayPrototype.slice.call(arguments, 1, -2); | |
| var groups = arraySlice(arguments, 1, -2); |
| for (var i = 0; i < groups.length; i++) { | ||
| var argumentIndex = i + 1; | ||
| if (groups[i] === '' && extendedGroups[i].mayBeMissing) { | ||
| arguments[argumentIndex] = undefined; |
There was a problem hiding this comment.
assigning to arguments is a massive deoptimization, and is mutation anyways. we'll have to avoid this.
es5-shim.js
Outdated
| } | ||
| } | ||
|
|
||
| return replaceValue.apply(this, arguments); |
There was a problem hiding this comment.
Suggested change
| return replaceValue.apply(this, arguments); | |
| return apply.call(replaceValue, this, arguments); |
|
ping @YLeight; i've rebased this, but there's still linting issues as well as mutation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ljharb I have added two tests which show thin places of both decisions in FF versions > 34 (current one and my previous one) from line 39 on
My current solution is a littlle bit difficult, but I have not found more simple one yet.