Add extended tests for defineProperty
#355
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE7 & 8, Safari 6, 7, 8 & 9, Chrome 26, 27, Node 0.8 & 0.10 all failed some of these tests.
Some versions of
eslint
also have a problem when linting these tests.The tests could use a little thinning out, and could give better detail of the problem. Some tests for default properties and if they work (on native) would probably also be nice.
Of course, failures here also generally mean failures in
defineProperties
aswell.