fix define empty descriptor

[yiminghe]

It should not throw error for empty descriptor

Object.defineProperty({},'a',{});

It is used in intl: https://github.com/andyearnshaw/Intl.js/blob/1fced3d60d004b9a853e3699cc6f3329096957da/src/core.js#L119

[ljharb]

This relates to #297, specifically #297 (comment)

In addition,

es5-shim/es5-sham.js

Line 340 in cd80ad1

Object.defineProperty(object, 'sentinel', {});

would need to change as well, preferably setting "value".

I think your change is good, but the question remains, what should happen if the descriptor is not empty? ie, if value is not provided, get and set are not provided, but configurable, enumerable, and writable are present? It seems to me like it should throw, whereas with your change, it would silently fail.

[yiminghe]

Get and set must throw, because old ie does not support it and the rest of code will fall definitely.

But others does not need to throw, warning is enough.

If you do not want to change, then I have to ask intl ...

[ljharb]

OK so since https://github.com/yiminghe/es5-shim/blob/definePropertyFix/es5-sham.js#L383-L395 is the current behavior of the "value" path, it should be the same behavior for the "non-value" path.

If ever those lines become uncommented, they'd be moved up and run in both code paths. So your change shouldn't affect that.

[schmod]

Thanks for taking the time to fix this. This is clearly an improvement over the current status quo :)

[ljharb]

I'll release this over the next couple days.