fix(render): respect color alpha channel in render_to_png#104
Open
mikhaelmartin wants to merge 2 commits into
Open
fix(render): respect color alpha channel in render_to_png#104mikhaelmartin wants to merge 2 commits into
mikhaelmartin wants to merge 2 commits into
Conversation
Contributor
|
This fixes the hardcoded alpha in the paint paths, but I think PNG encoding still needs attention. I'm happy to add a fix if you'd like. |
Author
|
@techwizrd Yes, please! I'm pretty new to this, so feel free to push the fix directly to this branch. Thank you so much for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103
render_to_pngdiscards the alpha channel fromColorvalues in all four paint paths. The pipeline correctly flowsColor::athroughLayoutOptions→DisplayList→ renderer, but each paint operation hardcodes alpha to 255:render_glyph_with_fontrender_linerender_rectrender_path_segmentThis replaces the hardcoded
255with(color.a * 255.0) as u8, matching how the RGB components already use(color.r * 255.0) as u8etc.