Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comma to specialCharacters list #819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grimalschi
Copy link

This solves wrong behaviour with escaped commas.

You can see this wrong behaiviour using "1. Hello, world!" phrase at https://parsedown.org/demo

Screenshot 2021-11-21 at 07 30 55

This is important because this kind of escape ("1. Hello, world!") produced by one of most famous markdown editors - TUI editor.

2021-11-21 07 34 23

If you write list without marking its as a real list, you will get this kind of escaping and then if you use result in Parsedown, you see "," instead of just commas.

This solves wrong behaviour with escaped commas.

You can see this wrong behaiviour using "1\. Hello\, world!" phrase at https://parsedown.org/demo
@grimalschi
Copy link
Author

grimalschi commented Nov 21, 2021

CommonMark also "unescapes" commas:
https://spec.commonmark.org/dingus/?text=1%5C.%20Hello%5C%2C%20world!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant