pyopenssl dependent endesive now optional #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniospneto
approved these changes
Mar 11, 2022
mbcosta
approved these changes
Mar 11, 2022
marcelsavegnago
approved these changes
Mar 11, 2022
renatonlima
force-pushed
the
remove-endesive-dep
branch
from
3c217f3 to
e79ae88
Compare
renatonlima
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o PR #26 removeu o xmlsec mas não foi suficente para remover totalmente a dependencia ao pyopenssl que esta deprecaded ( #26 (comment) )
Porque o erpbrasil.assinatura ainda depende da lib endesive que por sua vez depende do pyopenssl sem pena:
https://github.com/m32/endesive/blob/master/requirements.txt
Como não usamos o endesive em nada do OCA/l10n-brazil, o que eu fiz foi de simplesmente deixar a dependencia ao endesive optional: a funçao de assinatura de pdf funciona apenas se vc tiver o endesive instalado e senão avisa num log. Talvez seria possivel fazer uma implementação alternativa, mas por hoje isso é a forma simpĺes que eu vi de remover a dependencia ao pyopenssl no uso comum que a gente faz do erpbrasil.assinatura.
cc @renatonlima @mbcosta @marcelsavegnago @netosjb @mileo