Buffer data if needed when using socket send nowait #9879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 66 suites 26m 22s ⏱️ For more details on these failures, see this check. Results for commit fb132c1. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Closed
dgud
force-pushed
the
dgud/ssl/socket-async-send/OTP-19651
branch
5 times, most recently
from
511bbb5 to
e20ed00
Compare
dgud
force-pushed
the
dgud/ssl/socket-async-send/OTP-19651
branch
from
e20ed00 to
631ba35
Compare
dgud
requested review from
IngelaAndin,
RaimoNiskanen and
u3s
and removed request for
RaimoNiskanen and
IngelaAndin
IngelaAndin
reviewed
Jun 13, 2025
u3s
reviewed
Jun 18, 2025
dgud
force-pushed
the
dgud/ssl/socket-async-send/OTP-19651
branch
from
631ba35 to
c62a08b
Compare
IngelaAndin
reviewed
Jun 18, 2025
IngelaAndin
reviewed
Jun 18, 2025
IngelaAndin
reviewed
Jun 18, 2025
IngelaAndin
reviewed
Jun 23, 2025
gen_tcp (or rather inets) have a builtin buffer when socket is blocked, controlled by high[low]_watermark. Implement buffering and async send for sockets in tls_sender, to improve performance when using sockets.
Did not enter passive mode when {active, N} triggered,
i.e. activate was false.
Also improve error handling
Workaround cancel request on downgrade
Thus we can make send async if hanging on outgoing buffer.
dgud
force-pushed
the
dgud/ssl/socket-async-send/OTP-19651
branch
from
c62a08b to
fb132c1
Compare
IngelaAndin
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make socket usage behave like gen_tcp i.e. if socket would block buffer data up to high_watermark.