Use -fvisibility=hidden on entire beam executable #9864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if tests has been built with links to java files.
as it's only called via NIF API since long ago.
To not pollute the exported name space of the beam and avoid name clashes with linked in NIFs and drivers. mtx_SUITE had to be fixed. It now accesses the internal ethread API via a new peephole in erl_internal_test.h (even on Windows).
sverker
added
team:VM
CT Test Results 4 files 144 suites 50m 31s ⏱️ For more details on these failures, see this check. Results for commit 74112b7. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
reviewed
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the exported name space clean and only expose symbols of documented interfaces like NIF and driver APIs. This will avoid accidental name clashes with our statically linked variants of for example PCRE2 and ZSTD.