Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize and test coverage of pcre2 yielding #9610

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Optimize and test coverage of pcre2 yielding #9610

wants to merge 4 commits into from

Conversation

sverker
Copy link
Contributor

@sverker sverker commented Mar 19, 2025

No description provided.

@sverker
erts: Optimize pcre2 loops_left with restrict pointer
bc0a052 
The hope is that the C compiler will have easier to optimize
by caching the loops_left counter in a register.
@sverker sverker added team:VM Assigned to OTP team VM enhancement testing currently being tested, tag is used by OTP internal CI labels Mar 19, 2025
@sverker sverker self-assigned this Mar 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025 •
edited
Loading

CT Test Results

    4 files    227 suites   1h 55m 11s ⏱️
3 688 tests 3 586 ✅ 101 💤 1 ❌
4 797 runs  4 669 ✅ 127 💤 1 ❌

For more details on these failures, see this check.

Results for commit a47fd8b.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@sverker sverker requested a review from frazze-jobb March 19, 2025 15:01
@sverker sverker force-pushed the sverker/erts/pcre2-yield-improvements/OTP-19431 branch from 08d2615 to d0474f2 Compare March 25, 2025 15:12
sverker added 3 commits March 26, 2025 16:06
@sverker
erts: Add test of yield point coverage for debug build
fb1d0fd 
Also
* Kept macro DEBUG in build of pcre2_* files
* Renamed suffix of pcre2_match_loop_break_cases.inc to .gen.h
* Removed the strange +100 for yield point label names
@sverker
pcre2: Add missing #ifdef ERLANG_INTEGRATION
2dfb1c2
@sverker
pcre: Fix README.pcre_update.md
a47fd8b
@sverker sverker force-pushed the sverker/erts/pcre2-yield-improvements/OTP-19431 branch from d0474f2 to a47fd8b Compare March 26, 2025 15:06
@sverker
Copy link
Contributor Author

sverker commented Mar 26, 2025

@frazze-jobb I did another branching strategy in my pcre2 repo. I kept the ERLANG_INTEGRATION branch and changed your rebase on pcre2-10.45 into a merge of pcre2-10.45 into ERLANG_INTEGRATION. Then I tagged with OTP-28.0-rc1 and OTP-28.0-rc2. I think this will make it easier to follow the update history. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frazze-jobb frazze-jobb Awaiting requested review from frazze-jobb

At least 1 approving review is required to merge this pull request.

Assignees

@sverker sverker

Labels
enhancement team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sverker