Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ct: Add -out parameter to ct_run #7788

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

ct: Add -out parameter to ct_run #7788

wants to merge 2 commits into from

Conversation

jchristgit
Copy link
Contributor

Allow configuring an alternative logging destination instead of stdout for any logger reports using the new -out flag.

@jchristgit
ct: Allow configuring alternative logging destination
0f44b85 
Currently, the default logging handler used on startup logs and logger
messages to standard output. Implement the new option
`default_log_destination` in `cth_log_redirect` and the accompanying
option `-out` for `ct_run` to allow redirecting logs elsewhere, such as
a dedicated file or `/dev/null`.
@jchristgit
kernel: Do not sync logger messages to /dev/null
849b7bd
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

CT Test Results

       3 files     112 suites   2h 31m 12s ⏱️
1 861 tests 1 593 ✔️ 267 💤 1 ❌
2 076 runs  1 756 ✔️ 319 💤 1 ❌

For more details on these failures, see this check.

Results for commit 849b7bd.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@u3s u3s self-assigned this Oct 25, 2023
@u3s u3s added the team:PS Assigned to OTP team PS label Oct 25, 2023
@jchristgit
Copy link
Contributor Author

I've added the log reconfiguration function to cth_log_redirect but re-thinking this now, I'm not sure it has much to do with that hook at all. Maybe it should be sitting in ct_run itself instead?

Also, I didn't add this to ct:print yet per my comment in the original PR and #7427. Not sure if there is a clean way that I may be missing...

@u3s
Copy link
Contributor

u3s commented Nov 18, 2023

please wait with this PR. I need to analyze it further.

@jchristgit jchristgit mentioned this pull request Nov 19, 2023
Closed
@u3s
Copy link
Contributor

u3s commented Nov 28, 2023

If you agree, I would like to convert that one into a draft for a while.

I'm overwhelmed with other stuff and would like to park this one until:

  • cte_track (or equivalent) is in place
  • we adjusted couple of specs and know more about what is needed most in ct_run -out context
  • work on reducing CT output is ongoing (adjusting specs and checking what else is there to be done)

@jchristgit jchristgit marked this pull request as draft November 28, 2023 12:31
@jchristgit
Copy link
Contributor Author

Sounds good to me. I think with cth_log_redirect in place this one may need some changes anyhow. Let me know when or if I should change something on the PR, or if you feel another approach is better altogether.

@jchristgit jchristgit mentioned this pull request Mar 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@u3s u3s

Labels
priority:low team:PS Assigned to OTP team PS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchristgit @u3s @IngelaAndin