Copy request options during tls connection change

[itssundeep]

This should address the issue with #10368

[CLAassistant]

All committers have signed the CLA.

[github-actions]

CT Test Results

  2 files   23 suites   9m 52s ⏱️
365 tests 359 ✅  6 💤 0 ❌
718 runs  635 ✅ 83 💤 0 ❌

Results for commit a12a43a.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• No Windows Installer found

// Erlang/OTP Github Action Bot

[IngelaAndin]

@itssundeep You need to sign the CLA

[IngelaAndin]

I think the change looks sound. And I guess it is sort of complicated to write a test for it. Have you considered it? @Whaileee what do you think could we manage a test case?

[Whaileee]

From what I can tell this case, originating from connect_and_send_upgrade_request isn't covered by our testcases and I feel like it could use some testing. Would you like to try and write a testcase for that @itssundeep?
Best regards,
Konrad

[itssundeep]

@Whaileee I am not too familiar on how to simulate the error scenario in the test, so would prefer if someone else would take it up.