-
Notifications
You must be signed in to change notification settings - Fork 3k
global: use priority monitors
#10329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
global: use priority monitors
#10329
Conversation
CT Test Results 2 files 72 suites 1h 7m 1s ⏱️ For more details on these failures, see this check. Results for commit 3c70521. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
|
As an afterthought... there is also the |
|
The test failure seems unrelated to this PR, it occurs in |
|
Thanks for the PR! Have you considered how the changed message order could affect the rest of the code? |
Yes. Also, @juhlig reviewed it and found nothing amiss. However, message order is not all too easy to reason about, so yet another pair of eyes would be great. FWIW, we draw some additional confidence out of the fact that even as of now, |
I haven't found anything amiss either, and the tests (spartan as they are) haven't either in two weeks, so I'm looking at merging this later on this week. :-) |
OTP 28 introduced priority messages and prioritization of monitor messages. I think the
globalmodule is a good place to use them, in order to reduce (albeit not eliminate) the rejection of registrations when a registered process has just died but the resulting'DOWN'message has not yet been processed byglobal.