core.c: Include constants.h and make b2LogHandler static#1024
Open
Hymenium wants to merge 1 commit intoerincatto:mainfrom
Open
core.c: Include constants.h and make b2LogHandler static#1024Hymenium wants to merge 1 commit intoerincatto:mainfrom
Hymenium wants to merge 1 commit intoerincatto:mainfrom
Conversation
1. `b2LogHandler` seems to be a private global but is missing `static`. 2. `b2_lengthUnitsPerMeter` has its extern declaration in `constants.h`, but this header is not included (reversion from previous fix).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b2LogHandleris used as a private global but is missingstatic.b2_lengthUnitsPerMeterhas its extern declaration inconstants.h, but this header has been removed.