Updated MakeAsyncFunction prop types to accept an ActionMatcher #4
+48
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eject Update and reflect changes of redux-promise-listener 1.1.0
lutangar
force-pushed
the
fix/prop-types
branch
from
6edf093
to
9eb63ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 15 15
Branches 4 4
=====================================
Hits 15 15
Continue to review full report at Codecov.
|
|
I suppose the version number should be bumped to 1.1.0 but I don't know what's your strategy on this. Let me know. |
|
Is there any news on this @erikras ? |
qws777
approved these changes
Oct 21, 2019
|
Any updates on when this will be merged? |
istee
approved these changes
Oct 23, 2019
|
It's 2021 and I wonder what's the status on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @erikras
A few changes on the prop types/flow def/doc to allow an ActionMatcher on
resolveandrejectprops, without raising a warning (as seen in redux-promise-listener 1.1.0)Keep up the good work!
Cheers.