ci: restore discv5 to devp2p Hive shard#21512
Merged
Merged
Conversation
Re-applies the test-hive.yml half of #21065, which #21017 reverted in its "align test-hive devp2p sim-limit" commit: both devp2p matrix legs (serial + parallel exec) run sim-limit: eth|discv5 again, and the now-false "discv5 intentionally excluded" comment is dropped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
discv5 exercises peer discovery, not the EL exec path, so running it under both serial and parallel exec modes is redundant. Keep it in the parallel leg and document why the serial leg omits it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Restores discv5 coverage to the devp2p Hive shard by adding it to the parallel matrix leg only, since discv5 exercises peer discovery (not the EL exec path) and would be redundant in both legs.
Changes:
- Add
discv5to the parallel devp2p leg'ssim-limit(eth|discv5). - Keep the serial devp2p leg at
sim-limit: eth. - Add a comment explaining why
discv5runs in only one exec mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Giulio2002
approved these changes
May 29, 2026
Giulio2002
left a comment
Giulio2002
left a comment
Contributor
There was a problem hiding this comment.
LGTM — tiny CI-only workflow tweak that restores discv5 coverage in the intended Hive leg without touching product code.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores
discv5coverage to the devp2p Hive shard, which #21017 dropped from CI.#21065 added
discv5to the devp2p shard (sim-limit: eth|discv5), closing #17354. #21017 ("matrix-test serial vs parallel exec across the test workflows") then added aserial/parallelexec-mode axis and, in itsci: align test-hive devp2p sim-limitcommit, reverted both legs tosim-limit: eth— citing a comment that #21065 had itself deleted. That removed discv5 from CI entirely.#21017's underlying point was valid, though:
discv5exercises peer discovery, not the EL execution path, so running it under both exec modes would be redundant. So rather than re-adding it to both legs, this keepsdiscv5in the parallel leg only and documents why the serial leg omits it:sim-limit: ethsim-limit: eth|discv5hive-versions.jsonalready carries #21065's pins (hive_ref: 15750c9…,execution_apis_ref: 8d6b784…), sodiscv5runs against the same hive revision it originally passed on.Test plan
hivejob is not skipped — exercisingdevp2pdiscv5in the parallel exec leg.🤖 Generated with Claude Code