[performance] re-introduce block catchup recovery#21506
Open
sudeepdino008 wants to merge 2 commits into
Open
Conversation
Cherry-pick of #21415 to performance. - forkchoice: skip unwind path when unwindTarget >= TxNums.Last (state ahead of canonical). Cap-to-minUnwindable behaviour preserved inside the new wrapper. - aggregator: remove FrozenBlocksProvider / SetFrozenBlocksProvider and the cap branch in readyForCollation; the reorgBlockDepth gate is the single source of truth. - drop db/services/snapshot_progress.go (MaxCollatableTxNum helper) and its callers in node/eth/backend.go, cmd/integration, cmd/utils/app. - sync: hoist currentStage reset into a defer in Run / RunNoInterrupt so early returns can't leave the pipeline mid-stage. - tests: add TestUpdateForkChoiceRecoversWhenStateAheadOfTxNums and TestUpdateForkChoiceForwardExecutesAfterStateAheadRecovery; remove the FrozenBlocksProvider cap tests.
sudeepdino008
requested review from
AskAlexSharov,
Giulio2002,
mh0lt and
yperbasis
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #21415 to
performance.performance-specific adaptations
execution/execmodule/forkchoice.go: the new no-unwind branch wraps the existing cap-to-minUnwindable logic (performance keeps capping rather than returningReorgTooDeep, which doesn't exist on this branch).ExecutionStatusTooFarAwaydirectly (noExecutionStatusReorgTooDeepenum on performance).stage_snapshots.goalignStateToBlockSnapshotsremoval — not applicable; the function doesn't exist on this branch.