Bug 1898833 - Support oncontentvisibilityautostatechange event handle…

…r r=emilio,smaug Spec PR: whatwg/html#10364 Differential Revision: https://phabricator.services.mozilla.com/D217187
erichdongubler-mozilla · Jul 21, 2024 · 638712e · 638712e
1 parent 500a19b
commit 638712e
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 16 deletions.
diff --git a/dom/events/EventNameList.h b/dom/events/EventNameList.h
@@ -167,6 +167,8 @@ EVENT(click, ePointerClick, EventNameType_All,
           ? ePointerEventClass
           : eMouseEventClass)
 EVENT(close, eClose, EventNameType_HTMLXUL, eBasicEventClass)
+EVENT(contentvisibilityautostatechange, eContentVisibilityAutoStateChange,
+      EventNameType_All, eBasicEventClass)
 EVENT(contextmenu, eContextMenu,
       EventNameType_HTMLXUL | EventNameType_SVGGraphic,
       StaticPrefs::dom_w3c_pointer_events_dispatch_click_as_pointer_event()

diff --git a/dom/tests/mochitest/general/test_interfaces.js b/dom/tests/mochitest/general/test_interfaces.js
@@ -1679,6 +1679,8 @@ let interfaceNamesInGlobalScope = [
   // IMPORTANT: Do not change this list without review from a DOM peer!
   { name: "onclose", insecureContext: true },
   // IMPORTANT: Do not change this list without review from a DOM peer!
+  { name: "oncontentvisibilityautostatechange", insecureContext: true },
+  // IMPORTANT: Do not change this list without review from a DOM peer!
   { name: "oncontextlost", insecureContext: true },
   // IMPORTANT: Do not change this list without review from a DOM peer!
   { name: "oncontextmenu", insecureContext: true },

diff --git a/dom/webidl/EventHandler.webidl b/dom/webidl/EventHandler.webidl
@@ -39,6 +39,7 @@ interface mixin GlobalEventHandlers {
            attribute EventHandler onchange;
            attribute EventHandler onclick;
            attribute EventHandler onclose;
+           attribute EventHandler oncontentvisibilityautostatechange;
            attribute EventHandler oncontextlost;
            attribute EventHandler oncontextmenu;
            attribute EventHandler oncontextrestored;

diff --git a/...rm/meta/css/css-contain/content-visibility/content-visibility-auto-state-changed.html.ini b/...rm/meta/css/css-contain/content-visibility/content-visibility-auto-state-changed.html.ini
diff --git a/testing/web-platform/meta/trusted-types/trusted-types-event-handlers.html.ini b/testing/web-platform/meta/trusted-types/trusted-types-event-handlers.html.ini
@@ -50,6 +50,9 @@
   [Event handler div.onclose should be blocked.]
     expected: FAIL
 
+  [Event handler div.oncontentvisibilityautostatechange should be blocked.]
+    expected: FAIL
+
   [Event handler div.oncontextmenu should be blocked.]
     expected: FAIL
 

diff --git a/...tform/tests/css/css-contain/content-visibility/content-visibility-auto-state-changed.html b/...tform/tests/css/css-contain/content-visibility/content-visibility-auto-state-changed.html
@@ -24,16 +24,22 @@
 
 <script>
 let contentattrfired = false;
+let contentattrfiredonsvg = false;
 
 function contentattrDidFire() {
   contentattrfired = true;
 }
 
+function contentattrDidFireOnSvg() {
+  contentattrfiredonsvg = true;
+}
+
 </script>
 
 <div id=upper></div>
 <div id=attrtest></div>
 <div id=contentattrtest oncontentvisibilityautostatechange="contentattrDidFire()" class=auto></div>
+<svg id="svgcontentattrtest" oncontentvisibilityautostatechange="contentattrDidFireOnSvg()" class="auto"></svg>
 <div class=spacer></div>
 <div id=middle></div>
 <div class=spacer></div>
@@ -83,6 +89,12 @@
   assert_true(contentattrfired, "contentattrfired");
 }, "ContentVisibilityAutoStateChange content attribute test");
 
+
+promise_test(async t => {
+  await waitForAtLeastOneFrame();
+  assert_true(contentattrfiredonsvg, "contentattrfiredonsvg");
+}, "ContentVisibilityAutoStateChange content attribute test on svg");
+
 promise_test(t => new Promise(async (resolve, reject) => {
   await new Promise((waited, _) => {
     requestAnimationFrame(() => requestAnimationFrame(waited));

diff --git a/widget/EventMessageList.h b/widget/EventMessageList.h
@@ -214,6 +214,9 @@ NS_EVENT_MESSAGE(ePageHide)
 NS_EVENT_MESSAGE(eContextLost)
 NS_EVENT_MESSAGE(eContextRestored)
 
+// content-visibility events
+NS_EVENT_MESSAGE(eContentVisibilityAutoStateChange)
+
 // SVG events
 NS_EVENT_MESSAGE(eSVGLoad)
 NS_EVENT_MESSAGE(eSVGScroll)

diff --git a/xpcom/ds/StaticAtoms.py b/xpcom/ds/StaticAtoms.py
@@ -787,6 +787,7 @@
     Atom("onCheckKeyPressEventModel", "onCheckKeyPressEventModel"),
     Atom("onclick", "onclick"),
     Atom("onclose", "onclose"),
+    Atom("oncontentvisibilityautostatechange", "oncontentvisibilityautostatechange"),
     Atom("oncommand", "oncommand"),
     Atom("oncommandupdate", "oncommandupdate"),
     Atom("oncomplete", "oncomplete"),