Merge pull request #55 from erichbehrens/fix/clear-timeout-on-unmount

Clear timeout on component unmount
erichbehrens · Jul 4, 2018 · 17854c9 · 17854c9
2 parents 5aa8fb5 + dd2e95e
commit 17854c9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-animated-slider",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "description": "Animated slider component for react",
   "main": "build/index.js",
   "scripts": {

diff --git a/src/index.js b/src/index.js
@@ -58,6 +58,9 @@ class Slider extends React.PureComponent {
 
 	componentWillUnmount() {
 		this.stopAutoplay();
+		if (this.animationTimerId) {
+			clearTimeout(this.animationTimerId);
+		}
 	}
 
 	setupAutoplay = () => {
@@ -102,7 +105,8 @@ class Slider extends React.PureComponent {
 		if (this.isDisabled()) return;
 		this.nextSlideIndex = index;
 		this.setState({ animating: true, animation });
-		setTimeout(this.onAnimationEnd, this.props.duration || DEFAULT_DURATION);
+		const timeout = this.props.duration || DEFAULT_DURATION;
+		this.animationTimerId = setTimeout(this.onAnimationEnd, timeout);
 	};
 
 	previous = () => {