Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply opacity to cache #816

Closed
wants to merge 1 commit into from
Closed

Conversation

kzhdev
Copy link
Contributor

@kzhdev kzhdev commented Feb 18, 2014

No description provided.

@straumer
Copy link

This is exactly what I needed! I tested and it works nicely.

@kzhdev
Copy link
Contributor Author

kzhdev commented Feb 21, 2014

The cache mechanism has a bug in nested groups. You can get the fix from #787.

@lavrton
Copy link
Contributor

lavrton commented Mar 6, 2014

Bug here. Opacity will be applied twice (if cached object already has opacity).

@lavrton
Copy link
Contributor

lavrton commented Mar 6, 2014

May be we can reset opacity before caching (cache function):

var prevOpacity = this.getOpacity();
this.setOpacity(1);
this.drawScene(cachedSceneCanvas);
this.drawHit(cachedHitCanvas);
this.setOpacity(prevOpacity);

then apply opacity to cache

@kzhdev
Copy link
Contributor Author

kzhdev commented Mar 6, 2014

This was take care in pull request #787. We need to apply relative
opacity and scale to the cache not the absolute opacity.

On Wed, Mar 5, 2014 at 8:40 PM, Anton Lavrenov [email protected]:

May be we can reset opacity before caching (cache function):

var prevOpacity = this.getOpacity();this.setOpacity(1);this.drawScene(cachedSceneCanvas);this.drawHit(cachedHitCanvas);this.setOpacity(prevOpacity);

then apply opacity to cache

Reply to this email directly or view it on GitHubhttps://github.com//pull/816#issuecomment-36819455
.

@lavrton
Copy link
Contributor

lavrton commented May 12, 2014

close by cb52be6

@lavrton lavrton closed this May 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants