Skip to content

Commit

Permalink
Bump Rust toolchain channel from 1.70 to 1.71
Browse files Browse the repository at this point in the history
Upgrade the version of Rust and related tooling from 1.70.0 to 1.71.0,
which was recently released[1].

The `io_error_more` gate is still applicable (verified based on the
corresponding GitHub issue and running the tests with the related code
removed).

The Clippy configuration has been updated to explicity enable a new
rule from the "restriction" category (in addition to other rules that
are enabled by virtue of enabling other categories). No violations are
found by Clippy as a result of this toolchain bump.

--
1. https://blog.rust-lang.org/2023/07/13/Rust-1.71.0.html
  • Loading branch information
ericcornelissen committed Jul 14, 2023
1 parent 778a75c commit d6659d6
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ To be able to contribute you need the following tooling:

- [git] v2;
- [Just] v1;
- [Rust] and [Cargo] v1.70 (edition 2021) with [Clippy], [rustfmt] (see `rust-toolchain.toml`);
- [Rust] and [Cargo] v1.71 (edition 2021) with [Clippy], [rustfmt] (see `rust-toolchain.toml`);
- (Optional) [cargo-all-features] v1.7.0 or later;
- (Optional) [cargo-deny] v0.13.0 or later;
- (Optional) [cargo-mutants] v23.0.0 or later;
Expand Down
1 change: 1 addition & 0 deletions Justfile
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ _profile_prepare:
--deny clippy::print_stdout \
--deny clippy::rc_buffer \
--deny clippy::rc_mutex \
--deny clippy::ref_patterns \
--deny clippy::unwrap_used

@_vet_verify_project:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ rm -fq file1 file2

## Build from Source

To build from source you need [Rust] and [Cargo], v1.70 or higher, installed on your system. Then
To build from source you need [Rust] and [Cargo], v1.71 or higher, installed on your system. Then
run the command:

```shell
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Check out rustup at: https://rust-lang.github.io/rustup/index.html

[toolchain]
channel = "1.70.0"
channel = "1.71.0"
components = [
"cargo",
"clippy",
Expand Down
2 changes: 1 addition & 1 deletion src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2728,7 +2728,7 @@ mod rm {
trace!("remove {entry}");

if entry.is_dir() && !fs::is_empty(&entry) {
// This case is handled explicitly because, as of Rust 1.70, the `io::ErrorKind` variant
// This case is handled explicitly because, as of Rust 1.71, the `io::ErrorKind` variant
// is still experimental (gate "io_error_more") and so would result in an unknown error.
// This implementation leaves a possibility for a TOCTOU issue, but this will be handled
// safely as `std::fs::remove_dir` doesn't remove non-empty directories.
Expand Down

0 comments on commit d6659d6

Please sign in to comment.