Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace logrus zerolog #114

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Replace logrus zerolog #114

merged 11 commits into from
Mar 13, 2024

Conversation

Richard87
Copy link
Contributor

No description provided.

@Richard87 Richard87 linked an issue Mar 7, 2024 that may be closed by this pull request
Change Go logging library #110
Closed
@Richard87 Richard87 closed this Mar 7, 2024
@Richard87 Richard87 reopened this Mar 12, 2024
@Richard87 Richard87 self-assigned this Mar 12, 2024
@Richard87 Richard87 requested a review from nilsgstrabo March 12, 2024 17:03
nilsgstrabo
nilsgstrabo requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@nilsgstrabo nilsgstrabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

pkg/utils/logger/logger.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@Richard87 Richard87 requested a review from nilsgstrabo March 13, 2024 08:57
@Richard87 Richard87 merged commit c09c54c into main Mar 13, 2024
5 checks passed
@Richard87 Richard87 deleted the replace-logrus-zerolog branch March 13, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsgstrabo nilsgstrabo nilsgstrabo approved these changes

Assignees

@Richard87 Richard87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Go logging library
2 participants
@Richard87 @nilsgstrabo