Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matplotlib argument typing #445

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix matplotlib argument typing #445

merged 1 commit into from
Jul 8, 2024

Conversation

mferrera
Copy link
Collaborator

@mferrera mferrera commented Jul 8, 2024

matplotlib updating its typing and indicated that the method arguments changed in this commit should not receive lists, but tuples.

@mferrera mferrera self-assigned this Jul 8, 2024
@mferrera mferrera requested a review from a team July 8, 2024 06:10
matplotlib updated its type annotations and indicated that
the method arguments changed in this commit should not
receive lists, but tuples.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (dab68e7) to head (264ca9c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
- Coverage   98.80%   98.73%   -0.08%     
==========================================
  Files          17       17              
  Lines        2682     2682              
==========================================
- Hits         2650     2648       -2     
- Misses         32       34       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mferrera mferrera merged commit 407480f into equinor:main Jul 8, 2024
10 checks passed
@mferrera mferrera deleted the fix-mypy branch July 8, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants