Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing file to root #423

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

kwinkunks
Copy link
Member

Moved the contribution guidelines from the docs to the root folder. Included the root-level file in the docs, so no change there. Resolves #421.

This should not require the new file to be pointed at by the contributing 'help' in GitHub, because according to the docs

If a repository contains more than one CONTRIBUTING file, then the file shown in links is chosen from locations in the following order: the .github directory, then the repository's root directory, and finally the docs directory.

I actually did not know that about the docs directory, but in any case Equinor's guidelines ask for the file in the root dir.

Moved the contribution guidelines from the docs to the root folder.
Included the root-level file in the docs, so no change there.
Resolves equinor#421.
@kwinkunks kwinkunks requested a review from alifbe November 24, 2023 14:05
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8c385b) 98.98% compared to head (1778d5d) 98.98%.

❗ Current head 1778d5d differs from pull request most recent head 6fc8906. Consider uploading reports for the commit 6fc8906 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files          16       16           
  Lines        2558     2558           
=======================================
  Hits         2532     2532           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alifbe alifbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kwinkunks kwinkunks merged commit ea748d4 into equinor:main Nov 24, 2023
6 checks passed
@kwinkunks kwinkunks deleted the add-contributing-guidelines branch November 24, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contributing guidelines
3 participants