Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): add option to send runner type as parameter #383

Merged
merged 5 commits into from
Feb 8, 2024
Merged

feat(terraform): add option to send runner type as parameter #383

merged 5 commits into from
Feb 8, 2024

Conversation

chbul
Copy link
Contributor

@chbul chbul commented Feb 7, 2024

No description provided.

@chbul chbul self-assigned this Feb 7, 2024
@chbul chbul requested a review from a team as a code owner February 7, 2024 12:41
hknutsen
hknutsen reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@hknutsen hknutsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally name inputs after the arguments they set, so would it be better to name the input runs_on?

@hknutsen
Copy link
Member

hknutsen commented Feb 7, 2024 •
edited
Loading

See failing check. Contributing guidelines might prove useful there.

@chbul chbul changed the title Add option to send runner type as parameter feat(terraform): add option to send runner type as parameter Feb 7, 2024
@chbul chbul added the compliance Issues related to compliance label Feb 8, 2024
hknutsen
hknutsen approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@hknutsen hknutsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@chbul chbul merged commit 3560f76 into main Feb 8, 2024
7 checks passed
@chbul chbul deleted the add-large-runner-to-terraform-workflow branch February 8, 2024 10:17
@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Merged
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hknutsen hknutsen hknutsen approved these changes

Assignees

@chbul chbul

Labels
compliance Issues related to compliance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chbul @hknutsen