Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove Azure SQL DB restore workflow #349

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Conversation

hknutsen
Copy link
Member

@hknutsen hknutsen commented Jan 25, 2024

Fixes #339

@hknutsen
Copy link
Member Author

hknutsen commented Jan 25, 2024

@equinor/ops-coredev Do you think that this should be a breaking change instead, so that v9 marks the beginning of this repo being a collection of workflows that rely on some sort of source code? Ref. #339.

So PR would be updated like this:

feat!: remove Azure SQL DB restore workflow

Fixes #339

@kov117
Copy link
Contributor

kov117 commented Jan 25, 2024

Yeah i think that makes sense, that way we can sort of have it like a clean slate, as in it would be easier to read future updates, just like you how you wrote it with v9 being the begining.

@sefornes
Copy link
Contributor

I agree with @kov117. It makes a lot of sense.

@helenakallekleiv
Copy link
Contributor

It makes sense for it to be a breaking change, given the scope of this repo is "breaking" with the previous scope. Go for it 🎉

I kinda like the idea of having a collection of the automated operations, where azure-sqldb-restore.yml could be collected as a (for example) runbook script instead. An idea is to utilize the equinor/ops-automation repo, as the source of the collection, given there is room for this in the existing scope of the repo?

@hknutsen hknutsen marked this pull request as ready for review January 25, 2024 10:18
@hknutsen hknutsen requested a review from a team as a code owner January 25, 2024 10:18
@hknutsen hknutsen changed the title revert: remove Azure SQL DB restore workflow feat!: remove Azure SQL DB restore workflow Jan 25, 2024
@hknutsen
Copy link
Member Author

@helenakallekleiv Yes, this workflow would typically be implemented as an Azure Automation runbook in either equinor/ops-automation or a new equinor/ops-runbooks.

Copy link
Contributor

@kov117 kov117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@hknutsen hknutsen merged commit 41d734d into main Jan 25, 2024
6 checks passed
@hknutsen hknutsen deleted the hknutsen/issue339 branch January 25, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider what tasks to make workflows for
4 participants