docs: add troubleshooting for scripts #342
Conversation
There was a problem hiding this comment.
The instructions you've added are specifically for installing prerequisites and running the script on Windows, however the use of the word Bash implies that we're talking about a Unix-like system. Guessing this is a result of the script being run in Git Bash. I think that if these instructions are to be added, there should be made a very clear distinction between instructions for Bash (Unix) and Git Bash (Windows). I would probably replace the use of Git Bash with PowerShell for Windows-specific instructions myself, since it's the Windows-native shell, but feel free to disagree.
I added some suggestions that I think could make more sense, while still keeping your changes.
Also, according to this repos contributing guidelines, the PR title should not specify a scope, and the type should be chore, e.g. chore: add OIDC script troubleshooting or chore: oidc.sh troubleshooting
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
|
Updated PR title according to contributing guidelines. |
hknutsen
changed the title
hknutsen
dismissed
their stale review
Suggestions addressed outside of conversation.
Description
Add latest fix for running setup with BASH.