Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/29102 add sdk usage examples #61

Merged
merged 14 commits into from
Jan 9, 2025
Merged

Feature/29102 add sdk usage examples #61

merged 14 commits into from
Jan 9, 2025

Conversation

saraeq
Copy link
Contributor

@saraeq saraeq commented Jan 6, 2025

Description

We have simplified and restructured the notebook. We have also added more examples, all of them are listed under "Demo findings" in the task.
We have changed the name of the file with examples.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

We have tested the examples with different input and in different environments (dev, test and prod are possible to use).

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the architecture
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

saraeq and others added 9 commits December 11, 2024 12:56
@saraeq saraeq requested review from a team, JasonHansenEQU, janny93, AtleWebstep, asvindseth and nedv98 and removed request for a team January 6, 2025 12:20
janny93
janny93 reviewed Jan 6, 2025
View reviewed changes
src/omnia_timeseries/api.py Outdated Show resolved Hide resolved
janny93
janny93 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@janny93 janny93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good, but see comments. Could be good with some more description on the endpoints, but I think this is a good start :)

@saraeq
Fix comments in PR
f715131 
Add enum for federationSource, updated url and added some more description
janny93
janny93 reviewed Jan 7, 2025
View reviewed changes
src/omnia_timeseries/api.py Outdated Show resolved Hide resolved
@saraeq saraeq deployed to development January 9, 2025 08:44 — with GitHub Actions Active
@saraeq saraeq merged commit 63cb913 into main Jan 9, 2025
4 checks passed
@saraeq saraeq deleted the feature/29102-add-sdk-usage-examples branch January 9, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janny93 janny93 janny93 approved these changes

@nedv98 nedv98 nedv98 approved these changes

@JasonHansenEQU JasonHansenEQU Awaiting requested review from JasonHansenEQU JasonHansenEQU was automatically assigned from equinor/omnia-industrial-iot-team

@AtleWebstep AtleWebstep Awaiting requested review from AtleWebstep AtleWebstep was automatically assigned from equinor/omnia-industrial-iot-team

@asvindseth asvindseth Awaiting requested review from asvindseth asvindseth was automatically assigned from equinor/omnia-industrial-iot-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saraeq @janny93 @nedv98