Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: replace byValue with enums #1254

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner January 11, 2025 17:37
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.13%. Comparing base (0fe37d1) to head (38264f9).

Files with missing lines Patch % Lines
src/main/java/neqsim/thermo/phase/PhaseGE.java 50.00% 1 Missing ⚠️
...in/java/neqsim/thermo/phase/PhaseGEUnifacPSRK.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1254   +/-   ##
=========================================
  Coverage     41.13%   41.13%           
  Complexity     6030     6030           
=========================================
  Files           722      722           
  Lines         68334    68334           
  Branches       8162     8162           
=========================================
  Hits          28112    28112           
  Misses        38541    38541           
  Partials       1681     1681           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants