-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: MixingRuleTypeInterface #1250
Conversation
2ba88a6
to
3dd93e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good update!. I suggest you update the expected results in the test so they will pass (seem all of they are just minor changes).
09c710d
to
0622462
Compare
0622462
to
e4db51d
Compare
Found one more bug in my new code so after fixing that, there was no failing tests. |
New Interface CPAMixingRuleType
Introduce SuperInterface MixingRuleTypeInterface for EosMixingRuleType and CPAMixingRuleType
Make mixingrule concept generic for phases, prepare for future cleaner split between types using eos mixing and cpa mixing