Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: mixingrule getMixingRules #1242

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner January 9, 2025 10:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.06%. Comparing base (59c83bb) to head (dd6e39f).

Files with missing lines Patch % Lines
.../java/neqsim/thermo/mixingrule/CPAMixingRules.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1242   +/-   ##
=========================================
  Coverage     41.05%   41.06%           
+ Complexity     6008     6003    -5     
=========================================
  Files           719      719           
  Lines         68281    68233   -48     
  Branches       8174     8158   -16     
=========================================
- Hits          28036    28018   -18     
+ Misses        38557    38534   -23     
+ Partials       1688     1681    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmfstatoil asmfstatoil merged commit 3034fdb into equinor:master Jan 9, 2025
9 checks passed
@asmfstatoil asmfstatoil deleted the ref_setMixingRule_defined branch January 9, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants