Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EosMixingRuleType enum type and test #1237

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner January 7, 2025 10:19
@asmfstatoil asmfstatoil force-pushed the mixingrule_enum branch 2 times, most recently from 03621d7 to af331a0 Compare January 7, 2025 10:31
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 41.12%. Comparing base (9a34746) to head (01a1669).

Files with missing lines Patch % Lines
...c/main/java/neqsim/thermo/system/SystemThermo.java 50.00% 0 Missing and 5 partials ⚠️
...va/neqsim/thermo/mixingrule/EosMixingRuleType.java 73.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1237      +/-   ##
============================================
+ Coverage     41.07%   41.12%   +0.05%     
- Complexity     6006     6023      +17     
============================================
  Files           719      720       +1     
  Lines         68233    68252      +19     
  Branches       8158     8162       +4     
============================================
+ Hits          28024    28072      +48     
+ Misses        38528    38497      -31     
- Partials       1681     1683       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good update!

@asmfstatoil asmfstatoil force-pushed the mixingrule_enum branch 2 times, most recently from c2c868d to e440fb5 Compare January 9, 2025 10:38
@asmfstatoil asmfstatoil changed the title feat: add MixingRule enum type and test feat: add EosMixingRuleType enum type and test Jan 9, 2025
@asmfstatoil asmfstatoil force-pushed the mixingrule_enum branch 3 times, most recently from 261f266 to 17dd67c Compare January 9, 2025 12:36
@asmfstatoil asmfstatoil merged commit c25386a into equinor:master Jan 9, 2025
9 checks passed
@asmfstatoil asmfstatoil deleted the mixingrule_enum branch January 9, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants