Compile _gaussianfft.so with cmake and scikit-build-core #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindre-nistad
changed the title
sindre-nistad
force-pushed
the
refactor/cmake-base-building
branch
2 times, most recently
from
9157a17 to
f91db2c
Compare
|
Do we still need to support Python 3.6? |
I hope not, I've asked @oddvarlia, but I haven't heard back from him yet. |
sindre-nistad
force-pushed
the
refactor/cmake-base-building
branch
11 times, most recently
from
8b69074 to
6bed550
Compare
sindre-nistad
force-pushed
the
refactor/cmake-base-building
branch
from
6bed550 to
c120a94
Compare
sindre-nistad
force-pushed
the
refactor/cmake-base-building
branch
8 times, most recently
from
05bc093 to
181ba88
Compare
…fft` with `scikit-build-core` This in preparation for Python 3.11 and later, and to remove much of the logic in setup.py + make it easier to install `CMakeList.txt` is based on a sensible boilerplate cCourtesy of https://github.com/friendlyanon/cmake-init Using the template for a shared library (https://github.com/friendlyanon/cmake-init-shared-static)
sindre-nistad
force-pushed
the
refactor/cmake-base-building
branch
5 times, most recently
from
ce1c273 to
45869c2
Compare
dafeda
reviewed
Jan 16, 2024
sindre-nistad
force-pushed
the
refactor/cmake-base-building
branch
from
45869c2 to
cf7cf20
Compare
I'm having difficulties making `_gaussianfft.so` find the appropriate `libiomp.dylib` :(
sindre-nistad
force-pushed
the
refactor/cmake-base-building
branch
2 times, most recently
from
7119796 to
4a82899
Compare
Only use `dist` wheel during testing, because of conflicting version requirement in the two wheels after it was fixed by auditwheel
This avoids an issue where the wheels for linux where created as "dirty" (`.dev0` on tags)
Versions of Boost prior to 1.76.0 can be troublesome to compile; * Skip C++11 check when compiling older versions of Boost * Use Boost 1.76.0 or newer on macOS, and in the source distribution * Python Boost 1.74.0 seem to have problems with Python 3.10 and newer
sindre-nistad
force-pushed
the
refactor/cmake-base-building
branch
from
4a82899 to
f866475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines the build steps with
pyproject.toml, andcmake.This makes it possible to compile
gaussianfftfor newer versions of PythonThis should also make it easier to add more target platforms (e.g. Windows) and newer versions of Python.
Closes: #10, #12, #18