Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batch processing function #78

Merged
merged 5 commits into from
Dec 20, 2019
Merged

Add batch processing function #78

merged 5 commits into from
Dec 20, 2019

Conversation

berland
Copy link
Collaborator

@berland berland commented Dec 13, 2019

No description provided.

@berland
Copy link
Collaborator Author

berland commented Dec 13, 2019

This PR is there to help #77

Needs more thinking on the data structure sent as the batch argument.

@berland
Copy link
Collaborator Author

berland commented Dec 13, 2019

This might be ready unless someone comes with a better data structure for the list of batch commands, that simplifies syntax.

@berland berland requested a review from wouterjdb December 13, 2019 12:07
wouterjdb
wouterjdb requested changes Dec 13, 2019
View reviewed changes
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a really interesting step toward a better use of concurrent.futures!

src/fmu/ensemble/ensemble.py Outdated Show resolved Hide resolved
src/fmu/ensemble/ensembleset.py Outdated Show resolved Hide resolved
@berland
Copy link
Collaborator Author

berland commented Dec 16, 2019

Requested changes have been commited. Ready to merge.

@berland berland requested a review from wouterjdb December 19, 2019 08:19
wouterjdb
wouterjdb approved these changes Dec 20, 2019
View reviewed changes
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it could be good to add an example of running FMU ensemble in batch vs series in the documentation? Maybe with the timing there as well, to indicate what kind of speed gains one can expect.

src/fmu/ensemble/ensemble.py Outdated Show resolved Hide resolved
@berland
Copy link
Collaborator Author

berland commented Dec 20, 2019

This PR does not have any speed increases, so cannot comment on that.. It just enables concurrency by providing a general wrapper that results the Realization object after processing.

@berland berland mentioned this pull request Dec 20, 2019
Open
@berland berland merged commit e880a05 into master Dec 20, 2019
@berland berland deleted the batchreals branch December 20, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterjdb wouterjdb wouterjdb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berland @wouterjdb