Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Verify selection when refreshing current selection #9914

Merged

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Jan 30, 2025

Backport of 050077c

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el self-assigned this Jan 30, 2025
@andreas-el andreas-el changed the title Verify selection when refreshing current selection Backport: Verify selection when refreshing current selection Jan 30, 2025
@andreas-el andreas-el enabled auto-merge (rebase) January 30, 2025 10:31
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #9914 will not alter performance

Comparing andreas-el:backport_current_selection (630a386) with main (5dfbbd8)

Summary

✅ 24 untouched benchmarks
⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ test_plotter_on_all_snake_oil_responses_time[0] 11 s N/A N/A

@andreas-el andreas-el merged commit ec3894d into equinor:version-13.0 Jan 30, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants