Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine running of unit and performance tests #9854

Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 23, 2025

Should not have an effect on wait time for CI, but it improves the total time taken in CI because shared overhead is combined.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:build-system PR containing only build system changes label Jan 23, 2025
Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #9854 will degrade performances by 43.07%

Comparing eivindjahren:combine_performance_and_unit_tests (286e75b) with main (450d793)

Summary

❌ 6 (👁 6) regressions
✅ 18 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_parameters] 144.6 µs 253.1 µs -42.86%
👁 test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_parameters] 144.6 µs 253.9 µs -43.07%
👁 test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary-get_parameters] 148.2 µs 258.3 µs -42.64%
👁 test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary_with_obs-get_parameters] 143.9 µs 252.4 µs -43%
👁 test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_observations] 1.3 ms 1.5 ms -12.61%
👁 test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_observations] 2.4 ms 2.8 ms -12.23%

@@ -45,7 +45,13 @@ def test_escape(s: str) -> str:


def run_in_loop(coro: Awaitable[T]) -> T:
return get_event_loop().run_until_complete(coro)
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this makes sense!

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🚀

@eivindjahren eivindjahren merged commit 02df6ee into equinor:main Jan 23, 2025
27 checks passed
@eivindjahren eivindjahren deleted the combine_performance_and_unit_tests branch January 23, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:build-system PR containing only build system changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants