Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests for OMP_NUM_THREADS #9850

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 23, 2025

This test depends on a separate implementation of a flowrun executable, and an example of this executabe just changed implementation to always overwrite the environment variable OMP_NUM_THREADS in order to successfully control the behaviour of flow.

Issue
Resolves anticipated test failure after https://github.com/equinor/ert-configurations/pull/147

Approach
✂️

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This test depends on a separate implementation of a flowrun executable,
and an example of this executabe just changed implementation to always
overwrite the environment variable OMP_NUM_THREADS in order to successfully
control the behaviour of flow.
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Jan 23, 2025
@berland
Copy link
Contributor Author

berland commented Jan 23, 2025

Part of #8668

Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #9850 will not alter performance

Comparing berland:rm_omp_num_threads_tests (38274a9) with main (d1a2a88)

Summary

✅ 24 untouched benchmarks

@berland berland merged commit d21b16d into equinor:main Jan 23, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants