Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip testing lsf/openpbs in slurm specific test #9848

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 23, 2025

Issue
Resolves some CI-seconds. Partly solves #9847

Approach
Explicitness.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland self-assigned this Jan 23, 2025
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Jan 23, 2025
@berland berland enabled auto-merge (rebase) January 23, 2025 09:22
Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #9848 will not alter performance

Comparing berland:skiplsf_on_slurm (43193a5) with main (d4a49e4)

Summary

✅ 24 untouched benchmarks

@berland berland disabled auto-merge January 23, 2025 09:34
@berland berland force-pushed the skiplsf_on_slurm branch 2 times, most recently from 301756e to 5877c4c Compare January 23, 2025 09:42
Also use multiple workers since many tests do a lot
of sleeping.
@berland berland merged commit b3a7910 into equinor:main Jan 23, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants