Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ubuntu 24.04 workflows #9701

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JHolba
Copy link
Contributor

@JHolba JHolba commented Jan 9, 2025

This is not meant to be merged. It is just for testing purposes

Issue
ubuntu-latest will change to ubuntu-24.04 soon according to warnings emitted when pull requests are tested.

Approach
test if ubuntu-24.04 will cause any issues

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@JHolba JHolba self-assigned this Jan 9, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (1ae12f6) to head (29d7569).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9701      +/-   ##
==========================================
+ Coverage   91.71%   91.73%   +0.01%     
==========================================
  Files         426      426              
  Lines       26529    26529              
==========================================
+ Hits        24332    24336       +4     
+ Misses       2197     2193       -4     
Flag Coverage Δ
cli-tests 39.81% <ø> (ø)
everest-models-test 34.16% <ø> (-0.01%) ⬇️
gui-tests 74.35% <ø> (ø)
integration-test 37.99% <ø> (ø)
performance-tests 51.60% <ø> (-0.09%) ⬇️
test 39.53% <ø> (+<0.01%) ⬆️
unit-tests 74.22% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #9701 will not alter performance

Comparing JHolba:test-ubuntu-24.04-workflows (29d7569) with main (1ae12f6)

Summary

✅ 24 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants