Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor update workflow signature #9688

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frode-aarstad
Copy link
Contributor

Issue
Resolves #9607

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 9, 2025
@frode-aarstad frode-aarstad self-assigned this Jan 9, 2025
Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #9688 will not alter performance

Comparing frode-aarstad:refactor-update-workflow-sig (a15a674) with main (3a31ffb)

Summary

✅ 24 untouched benchmarks

@frode-aarstad frode-aarstad force-pushed the refactor-update-workflow-sig branch from 5637350 to 982ca1b Compare January 9, 2025 09:20
@frode-aarstad frode-aarstad force-pushed the refactor-update-workflow-sig branch from 982ca1b to a15a674 Compare January 9, 2025 09:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.77%. Comparing base (383d645) to head (a15a674).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9688      +/-   ##
==========================================
+ Coverage   91.74%   91.77%   +0.03%     
==========================================
  Files         426      426              
  Lines       26518    26554      +36     
==========================================
+ Hits        24328    24369      +41     
+ Misses       2190     2185       -5     
Flag Coverage Δ
cli-tests 39.67% <100.00%> (-0.03%) ⬇️
everest-models-test 34.19% <50.00%> (-0.04%) ⬇️
gui-tests 74.36% <100.00%> (+2.41%) ⬆️
integration-test 38.05% <50.00%> (-0.02%) ⬇️
performance-tests 51.61% <100.00%> (-0.04%) ⬇️
test 39.56% <50.00%> (-0.04%) ⬇️
unit-tests 74.25% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor update workflow signature
2 participants